-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eslint-plugin): check optional chaining for floating promises #4096
fix(eslint-plugin): check optional chaining for floating promises #4096
Conversation
Thanks for the PR, @G-Rath! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Codecov Report
@@ Coverage Diff @@
## master #4096 +/- ##
==========================================
+ Coverage 93.11% 93.33% +0.21%
==========================================
Files 174 152 -22
Lines 9619 8029 -1590
Branches 3004 2576 -428
==========================================
- Hits 8957 7494 -1463
+ Misses 248 180 -68
+ Partials 414 355 -59
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
let expression = node.expression; | ||
|
||
if (expression.type === AST_NODE_TYPES.ChainExpression) { | ||
expression = expression.expression; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: this is similar to skipChainExpression
from padding-line-between-statements
. You might consider making a util for it? I imagine this situation is one that will keep coming up.
Not a blocker, just a thought!
PR Checklist
Overview
Changes
no-floating-promises
to "expand" optional chain so that it's expression is checked.